Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108102/#review24910
-----------------------------------------------------------

Ship it!


looks good.


plasma/generic/applets/digital-clock/clock.cpp
<http://git.reviewboard.kde.org/r/108102/#comment19113>

    the opening { should be on the same line as the if statement, like all other if statements in this file :)


- Aaron J. Seigo


On Jan. 5, 2013, 3:14 a.m., Chao Feng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108102/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 3:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Bug 289427 is caused by a endless loop when searching for lagrest suitable font.
> If the largest size of current system font is still smaller than the shown area,
> the font.pointSize is increased but the resulting size QRect is the same.
> So the do...while loop will loop forever and consume 100% cpu runtime.
> 
> Fix:
> Check whether the resulting QRect is still increasing. If not, end the loop.
> 
> 
> This addresses bug 289427.
>     http://bugs.kde.org/show_bug.cgi?id=289427
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.cpp 708cb1ed105d636d3568295b134f4bcb55c4dfd6 
> 
> Diff: http://git.reviewboard.kde.org/r/108102/diff/
> 
> 
> Testing
> -------
> 
> Tested ok on Arch Linux + KDE 4.9.95
> 
> 
> Thanks,
> 
> Chao Feng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/2842b17d/attachment.html>