Review Request: fix kwin tabbox shadow

[Weng Xuetian]

Well.. since my mail to kcd is still being moderated I guess I'd also post
this patch here.

RFC: QML shadow patch, and handle mask correctly.

Screen shot.
http://wstaw.org/m/2013/01/07/plasma-desktopoj1171.png

The non-composite side is not affected as far as I tested. Shadow will not
be shown if composite is not enabled.


On Mon, Jan 7, 2013 at 7:06 AM, Martin Gräßlin <mgraesslin at kde.org> wrote:

> On Monday 07 January 2013 12:51:47 Marco Martin wrote:
> > On Monday 07 January 2013, Martin Gräßlin wrote:
> > > >     if that's so, then all that needs be done is to add the shadows
> by
> > > >     name in the rendering in the tabbox. shadow-top, etc. this can be
> > > >     done easily in the QML itself, and the problem would be solved.
> > >
> > > erm how?
> > >
> > >     PlasmaCore.FrameSvgItem {
> > >
> > >         id: shadowTop
> > >         imagePath: "shadow-top"
> > >
> > >     }
> > >
> > > and if that's possible it should be done for all the OSD and everything
> > > which does not have a problem with shadows being part of the window for
> > > performance reasons.
> >
> > the following should work fine:
> >      PlasmaCore.FrameSvgItem {
> >          id: shadow
> >          svg:Svg{imagePath: "shadow"}
> >      }
> and how to anchor it? The current code just uses:
>
>     PlasmaCore.FrameSvgItem {
>         id: background
>         anchors.fill: parent
>         imagePath: "dialogs/background"
>     }
>
> and I honestly have no idea how I should do it now. Also how does it affect
> the non-composited case?
> >
> > --
> > Marco Martin
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/8c1ee138/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwin-qml-shadow.patch
Type: application/octet-stream
Size: 7189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/8c1ee138/attachment.obj>