Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108115/#review24882
-----------------------------------------------------------


i didn't see this review before i went in and just fixed it. there were a few other issues in the code there that also needed fixing (like exposing widgets as public members of the class) and various usability issues (button naming, etc). so this is already handled in master.

- Aaron J. Seigo


On Jan. 5, 2013, 4:18 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108115/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 4:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> In this patch i am replacing the QDialogButtonBox with theQVBoxLayout.
> Also i have increase the size of the dialog, because it was too small for the labels.
> 
> 
> Diffs
> -----
> 
>   plasmate/savesystem/commitdialog.cpp cf7cb1f 
> 
> Diff: http://git.reviewboard.kde.org/r/108115/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> after
>   http://git.reviewboard.kde.org/r/108115/s/980/
> before
>   http://git.reviewboard.kde.org/r/108115/s/981/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/2cc0760c/attachment.html>