Review Request: Don't add qml elements twice to the scene, reduce warnings
Commit Hook
null at kde.org
Wed Jan 2 17:38:20 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108079/#review24450
-----------------------------------------------------------
This review has been submitted with commit 550faf2304a915a2b9b6b3d46dc14c42820d0430 by Aleix Pol to branch KDE/4.10.
- Commit Hook
On Jan. 2, 2013, 2:20 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108079/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2013, 2:20 p.m.)
>
>
> Review request for kdelibs, Plasma and Marco Martin.
>
>
> Description
> -------
>
> don't addItem to the scene after calling setParentItem. It's redundant according to the api documentation and removes a warning.
>
>
> Diffs
> -----
>
> plasma/widgets/declarativewidget.cpp 81f09c3
>
> Diff: http://git.reviewboard.kde.org/r/108079/diff/
>
>
> Testing
> -------
>
> Ran some plasmoids, works fine.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130102/5006b8ea/attachment.html>
More information about the Plasma-devel
mailing list