Review Request 109124: qml port currentappcontrol

[Kai Uwe Broulik]

> On Feb. 26, 2013, 1:36 p.m., Aaron J. Seigo wrote:
> > - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet?
> > 
> > a WindowSystem qml import would probably be the trick here, and it should be designed with the kwin team.
> > 
> > - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
> > 
> > as other users of this do shrink, my guess without looking would be that it is a QML issue and the item is not actually getting resized.
> > 
> > - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible?
> > 
> > you can load an icon file from the svg theme and specify the element to use, e.g.: "source: svgname-elementname"
> > 
> > - do you know how to read the size of the containment the widget is contained?
> > 
> > no, and this should never be required.
> 
> Greg T wrote:
>     - - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
>     - as other users of this do shrink, my guess without looking would be that it is a QML issue and the item is not actually getting resized.
>     
>     I've checked my qml code with a onMinimumHeightChanged handler and the size is set correctly. Well, now I've set maximumHeight to minimumHeight. That does the trick!
>     
>     - you can load an icon file from the svg theme and specify the element to use, e.g.: "source: svgname-elementname"
>     
>     After checking IconItem source, I don't even begin to understand how that can work. First of all it splits for '-' and would try to load 'widgets/configuration' which doesn't even exist
>     i.e.: source: "widgets/configuration-icons-maximize"
>     
>     - - do you know how to read the size of the containment the widget is contained?
>     - no, and this should never be required.
>     
>     sorry for providing insufficient data, but how would you implement this: 
>     const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 + fm.width('M')*30), containment()->size().width()/4);
>     on small screens the compactRepresentation of currentappcontrol shouldn't take the whole panel width

Concerning the svg stuff, load the SVG like so:
    PlasmaCore.Svg {
        id: configurationIconsSvg
        imagePath: "widgets/configuration-icons"
    }
and then you can use
        svg: configurationIconsSvg
        elementId: "maximize"
to access it


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/#review28133
-----------------------------------------------------------


On Feb. 25, 2013, 6:20 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109124/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 6:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Heya folks,
> This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete.
> Missing features/bugs:
> - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet?
> - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
> - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible?
> - do you know how to read the size of the containment the widget is contained?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 
>   plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 
>   plasma/netbook/applets/currentappcontrol/Messages.sh 45d44681ae1be43b2d71ca48ab3e77af37ad8861 
>   plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION 
>   plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION 
>   plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130228/d5b4fa75/attachment.html>