Review Request 108662: Fix build with OAuth present and QJson missing

Christoph Feck christoph at maxiom.de
Mon Feb 25 23:23:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108662/#review28087
-----------------------------------------------------------

Ship it!


Ship It!

- Christoph Feck


On Feb. 25, 2013, 1:45 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108662/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 1:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> A user downstream reported that building with OAuth enabled and QJSon disabled fails, since microblog unconditionally requires QJson.
> 
> This patch updates the condition to build microblog appropriately.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eba537c7780489113624c678e57048ce57542f0c 
>   dataengines/CMakeLists.txt c86be79a1702244c618e4335bf69092616e05c3b 
> 
> Diff: http://git.reviewboard.kde.org/r/108662/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130225/343762da/attachment.html>


More information about the Plasma-devel mailing list