Review Request 109124: qml port currentappcontrol

[Greg T]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 6:20 p.m.)


Review request for Plasma.


Changes
-------

boo-boos fixed. the main issues are still present, see top. help appreciated!


Description
-------

Heya folks,
This is a qml port of the netbook applet currentappcontrol. It's ready to use, but not fully complete.
Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?


Diffs (updated)
-----

  CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 
  plasma/netbook/applets/currentappcontrol/CMakeLists.txt 46178ce3a9351845855e9fccfbc13a9d3946fc95 
  plasma/netbook/applets/currentappcontrol/Messages.sh 45d44681ae1be43b2d71ca48ab3e77af37ad8861 
  plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION 
  plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION 
  plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109124/diff/


Testing
-------


Thanks,

Greg T

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130225/36bbdb02/attachment.html>