Review Request 108992: Simple optimizations in SignalPlotter
Raul Fernandes
rgfernandes at gmail.com
Wed Feb 20 21:51:35 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108992/#review27798
-----------------------------------------------------------
Ship it!
Ship It!
- Raul Fernandes
On Feb. 17, 2013, 12:57 p.m., Raul Fernandes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108992/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2013, 12:57 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> - create variables and classes outside the loops
> - reserve space in QList if we know already how many items will be added (avoid unnecessary reallocations)
> - use const_iterator when possible
> - remove a useless call (p->setPen(Qt::NoPen) - it will be set latter before be used)
> - avoid multiplications (x3, x2, x1 and x0)
>
>
> Diffs
> -----
>
> plasma/widgets/signalplotter.cpp 8e9e294
>
> Diff: http://git.reviewboard.kde.org/r/108992/diff/
>
>
> Testing
> -------
>
> I have tested with KDE 4.10 with no problems.
> I have seen a improvement of about 5% in drawPlots() function, the most expensive function in painting.
>
>
> Thanks,
>
> Raul Fernandes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130220/0cdf8327/attachment-0001.html>
More information about the Plasma-devel
mailing list