Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.
Tjaart Blignaut
tjaartblig at gmail.com
Mon Feb 18 21:34:01 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108969/
-----------------------------------------------------------
(Updated Feb. 18, 2013, 11:34 p.m.)
Review request for Plasma.
Changes
-------
Made text size weight a little less for smaller screens, trying to find a happy medium.
Description
-------
This patch
- allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size.
- makes the play controls slighty bigger and easier to press
- Adds some margins to all the controls
- makes the progress bar a bit fatter
- Removed the "by" and "on" text
Diffs (updated)
-----
applets/nowplaying/package/contents/ui/Controls.qml 382ccf6
applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6
applets/nowplaying/package/contents/ui/MetadataPanel.qml dc01be6
Diff: http://git.reviewboard.kde.org/r/108969/diff/
Testing
-------
Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically.
File Attachments
----------------
Before
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png
After
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png
With play controls
http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png
Thanks,
Tjaart Blignaut
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130218/7115146a/attachment.html>
More information about the Plasma-devel
mailing list