Review Request 108922: Fix off-by-one error in RunnerModel

Sebastian Kügler sebas at kde.org
Sat Feb 16 13:48:12 UTC 2013



> On Feb. 16, 2013, 1:47 p.m., Commit Hook wrote:
> > This review has been submitted with commit 1e13f5718e712ee75dfc05b5d1bb017b6926b5a4 by Sebastian Kügler to branch master.

This is the frameworks commit, I did not put it into kde-runtime, just making sure it won't get lost.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108922/#review27545
-----------------------------------------------------------


On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108922/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 3:10 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Fix off-by-one error in RunnerModel
> 
> The last argument of beginInsertRows() is the row number of the last
> inserted row, not the one for the row after.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/runnermodel.cpp ee1b54d45e02f1db8650219e08f6950d0e732a85 
> 
> Diff: http://git.reviewboard.kde.org/r/108922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130216/50cc6e16/attachment.html>


More information about the Plasma-devel mailing list