Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108969/#review27493
-----------------------------------------------------------


Beautiful!


applets/nowplaying/package/contents/ui/Controls.qml
<http://git.reviewboard.kde.org/r/108969/#comment20652>

    You might want to make this adjust to font dpi settings or global icon sizes.



applets/nowplaying/package/contents/ui/Controls.qml
<http://git.reviewboard.kde.org/r/108969/#comment20653>

    Whitespace, remove.



applets/nowplaying/package/contents/ui/FullLayout.qml
<http://git.reviewboard.kde.org/r/108969/#comment20654>

    Debugging leftover?



applets/nowplaying/package/contents/ui/FullLayout.qml
<http://git.reviewboard.kde.org/r/108969/#comment20655>

    Whitespace



applets/nowplaying/package/contents/ui/FullLayout.qml
<http://git.reviewboard.kde.org/r/108969/#comment20656>

    Remove?



applets/nowplaying/package/contents/ui/FullLayout.qml
<http://git.reviewboard.kde.org/r/108969/#comment20657>

    Whitespace



applets/nowplaying/package/contents/ui/FullLayout.qml
<http://git.reviewboard.kde.org/r/108969/#comment20658>

    Whitespace


- Kai Uwe Broulik


On Feb. 14, 2013, 10:01 p.m., Tjaart Blignaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108969/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 10:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch 
> - allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size.
> - makes the play controls slighty bigger and easier to press
> - Adds some margins to all the controls
> - makes the progress bar a bit fatter
> - Removed the "by" and "on" text
> 
> 
> Diffs
> -----
> 
>   applets/nowplaying/package/contents/ui/Controls.qml 382ccf6 
>   applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6 
>   applets/nowplaying/package/contents/ui/MetadataPanel.qml dc01be6 
> 
> Diff: http://git.reviewboard.kde.org/r/108969/diff/
> 
> 
> Testing
> -------
> 
> Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png
> 
> 
> Thanks,
> 
> Tjaart Blignaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130215/598f3bda/attachment-0001.html>