Review Request 104281: Drop Decorations B2, Laptop and Plastik

[Martin Gräßlin]

> On Feb. 7, 2013, 10:25 p.m., Albert Astals Cid wrote:
> > I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?
> 
> Aaron J. Seigo wrote:
>     plastik is gone, but b2 and laptop are still there.
> 
> Albert Astals Cid wrote:
>     Is anyone planning to take care of that removal? Martin? Thomas?
> 
> Thomas Lübking wrote:
>     Regarding the bug reports about "plastik became slow" i'd say such movement (at least for Laptop) is only possible along the introduction of a maintained legacy decoration.
>     I sent a round an RFC reg. a deco for low (network) overhead and maximum usability (so we've a "failsafe" decoration for ppl. with bad eys or weird network setups with the WM remote) but got no comment on that (needs input from a11y and HIG and possibly a veto from the oxygen team)
> 
> Martin Gräßlin wrote:
>     As Thomas wrote: it's blocked by waiting for a (maintained) legacy decoration. The decorations need to go (B2 is intercepting XEvents, Laptop is just broken), but they are currently our only chance to offer something useable for remote users (not that I would say it's a valid use case in 2013).
> 
> Aaron J. Seigo wrote:
>     i don't know how long ago the RFC for this replacement deco went out, so perhaps this is not the case, but ... -> if you are not getting feedback from a11y/HIG, please don't let that hold up such changes. it's best to get that feedback, but if there is simply no feedback after a reasonable amount of time and a couple tries (2 times in 6 months is pretty forgiving, imho) then my vote would be to simply push forward and do your best.
> 
> Martin Gräßlin wrote:
>     I really don't want to break the last bit of remote setups. The users are already angry enough with us for removing the drawbound while moving.
>     
>     So the decorations have to stay till there is a decoration for remote setups, which obviously needs someone to write it.
> 
> Albert Astals Cid wrote:
>     So maybe discard the review request for now?

given that it wouldn't apply anyway - yeah.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104281/#review26898
-----------------------------------------------------------


On March 29, 2012, 11:27 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104281/
> -----------------------------------------------------------
> 
> (Updated March 29, 2012, 11:27 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> As discussed on mailinglist: http://lists.kde.org/?l=kwin&m=133136239707091&w=2
> 
> 
> Diffs
> -----
> 
>   kwin/clients/CMakeLists.txt 6019a9e 
>   kwin/clients/b2/CMakeLists.txt 9295cbe 
>   kwin/clients/b2/b2.desktop 2846e39 
>   kwin/clients/b2/b2client.h c9e9b57 
>   kwin/clients/b2/b2client.cpp 6b52996 
>   kwin/clients/b2/bitmaps.h 00c4552 
>   kwin/clients/b2/config/CMakeLists.txt 1aaf8da 
>   kwin/clients/b2/config/config.h c5bc33c 
>   kwin/clients/b2/config/config.cpp fc9c7b9 
>   kwin/clients/laptop/CMakeLists.txt 1f4d600 
>   kwin/clients/laptop/laptop.desktop ccc9d54 
>   kwin/clients/laptop/laptopclient.h 4f1196d 
>   kwin/clients/laptop/laptopclient.cpp 52efcd1 
>   kwin/clients/plastik/CMakeLists.txt fce0829 
>   kwin/clients/plastik/config/CMakeLists.txt e48955d 
>   kwin/clients/plastik/config/config.h b037efe 
>   kwin/clients/plastik/config/config.cpp a4ddfe0 
>   kwin/clients/plastik/config/configdialog.ui fe9f53a 
>   kwin/clients/plastik/plastik.h ae7a46e 
>   kwin/clients/plastik/plastik.cpp ff9825f 
>   kwin/clients/plastik/plastik.desktop 30550c6 
>   kwin/clients/plastik/plastikbutton.h 395f628 
>   kwin/clients/plastik/plastikbutton.cpp db29d76 
>   kwin/clients/plastik/plastikclient.h 4c5b0d9 
>   kwin/clients/plastik/plastikclient.cpp 58f8324 
> 
> Diff: http://git.reviewboard.kde.org/r/104281/diff/
> 
> 
> Testing
> -------
> 
> it compiles
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130212/6da4eae4/attachment-0001.html>