Review Request 108223: use Plasma::Dialog for kmix osd

[Aaron J. Seigo]

> On Feb. 10, 2013, 10:04 a.m., Christian Esken wrote:
> > Just got a bug report that is likely realted to this change ("started happening on kde 4.10"): Bug 314803 - OSD glitches out and freezes
> > https://bugs.kde.org/show_bug.cgi?id=314803

what leads you believe it is related to this change?

i've noticed that problem as well, though i believe it was well before this got merged in.

what i find happens is that if i press and hold the volume up/down button, the OSD will jump and then go back and jump again .. and sometimes eventually just freeze. so if it starts at 50% and i press and hold it will go 55, 60, 70, 55, 80, 60, 65, 70, 75, 80, 85 ... i don't see how that has anything to do with this patch?

also, when it freezes, sometimes (perhaps always, but i can't say for sure) even the kmix icon in the systemtray (which remains otherwise interactive) won't let me adjust the volume.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108223/#review27114
-----------------------------------------------------------


On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108223/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 11:52 p.m.)
> 
> 
> Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian Esken.
> 
> 
> Description
> -------
> 
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for kmix osd.
> 
> 
> Diffs
> -----
> 
>   gui/osdwidget.h 9ec0100 
>   gui/osdwidget.cpp 2dc202e 
> 
> Diff: http://git.reviewboard.kde.org/r/108223/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130212/fa1c3485/attachment.html>