Review Request 106112: Pager QML port

[Luís Gabriel Lima]

> On Feb. 9, 2013, 6:49 p.m., Mark Gaiser wrote:
> > Just wanted to add that it has a regression that slipped in the 4.10.0 release. https://bugs.kde.org/show_bug.cgi?id=312684
> > 
> > If you have only one virtual desktop the pager just shows an empty area. That is obviously wrong. It is actually very clearly visible in this - long - review: http://www.muktware.com/5194/kde-410-review-time-switch-kde. Just look at the first image, the gap between activity icon and dolphin is the pager.

Actually it's not a regression. As you can see in the history of this review, it was requested to hide the pager when there is only one virtual desktop. Although I can see a bug in the current implementation, the pager should be considerably small (practically hidden). Right now it's just making the virtual desktop rect invisible and keeping the same size.


- Luís Gabriel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106112/#review27093
-----------------------------------------------------------


On Aug. 30, 2012, 2:30 a.m., Luís Gabriel Lima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106112/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 2:30 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch contains the QML port of the Pager plasmoid done during the GSoC 2012.
> 
> In this port basically I used QML to paint the Pager UI and deal with the user interaction. 
> The geometry calculation of the desktop and window rectangles was kept in C++ as well as other routines that needs to interact with classes like KWindowSystem, QDbusConnection and so on.
> This patch also introduces the PagerModel, a QAIM subclass that holds the desktop/window geometries and is used by the QML part to fill the UI.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/pager/CMakeLists.txt 5d80514 
>   plasma/desktop/applets/pager/model.h PRE-CREATION 
>   plasma/desktop/applets/pager/model.cpp PRE-CREATION 
>   plasma/desktop/applets/pager/package/contents/ui/main.qml PRE-CREATION 
>   plasma/desktop/applets/pager/package/contents/ui/utils.js PRE-CREATION 
>   plasma/desktop/applets/pager/package/metadata.desktop PRE-CREATION 
>   plasma/desktop/applets/pager/pager.h 6c7c045 
>   plasma/desktop/applets/pager/pager.cpp 74dc529 
> 
> Diff: http://git.reviewboard.kde.org/r/106112/diff/
> 
> 
> Testing
> -------
> 
> - Tested inside panels and floating on desktop, sizing works as expected
> - Mouse interactions (move windows around, change desktop, etc)
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/106112/s/691/
> 
>   http://git.reviewboard.kde.org/r/106112/s/692/
> 
> 
> Thanks,
> 
> Luís Gabriel Lima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130211/00b7f625/attachment.html>