Review Request 104417: Copy files instead of moving if parent dir is not writable

[Ivan Čukić]

> On Feb. 8, 2013, 11 p.m., Albert Astals Cid wrote:
> > Lamarque? Ivan? Are you guys working on this or should I just mark it as discarded?

You can mark it as discarded - there are no more private activities


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/#review27029
-----------------------------------------------------------


On Feb. 8, 2013, 10:59 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104417/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 10:59 p.m.)
> 
> 
> Review request for KDE Runtime, Plasma and Ivan Čukić.
> 
> 
> Description
> -------
> 
> When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.
> 
> 
> This addresses bug 296808.
>     http://bugs.kde.org/show_bug.cgi?id=296808
> 
> 
> Diffs
> -----
> 
>   service/jobs/nepomuk/Move.h 8a8afd1 
>   service/jobs/nepomuk/Move.cpp 2248768 
> 
> Diff: http://git.reviewboard.kde.org/r/104417/diff/
> 
> 
> Testing
> -------
> 
> Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image".
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130209/c96ae297/attachment.html>