Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

[Marco Martin]

> On Feb. 7, 2013, 9:39 a.m., Marco Martin wrote:
> > Ship It!

ah, another thing.
from now on, patches done here should be applied also in the corresponding file in the plasma-frameworks repository when applicable


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108825/#review26828
-----------------------------------------------------------


On Feb. 7, 2013, 1:22 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108825/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2013, 1:22 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Whenever I started muon-discover I had a lot of issues from QPainter.
> After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0.
> 
> This patch makes sure that we don't even try to paint empty icons, which solves the problem.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/core/iconitem.cpp 765e7ed 
> 
> Diff: http://git.reviewboard.kde.org/r/108825/diff/
> 
> 
> Testing
> -------
> 
> After patching, ran discover again, without all the qWarnings.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130207/a1875a52/attachment.html>