Review Request 108825: Fix QPainter problem in IconItem when trying to paint an icon with size==0

Aleix Pol Gonzalez aleixpol at gmail.com
Thu Feb 7 01:22:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108825/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

Whenever I started muon-discover I had a lot of issues from QPainter.
After some investigation (gdb + breakpoint to qWarning) I found out the problem was that we were trying to render a QIcon with size equal to 0.

This patch makes sure that we don't even try to paint empty icons, which solves the problem.


Diffs
-----

  plasma/declarativeimports/core/iconitem.cpp 765e7ed 

Diff: http://git.reviewboard.kde.org/r/108825/diff/


Testing
-------

After patching, ran discover again, without all the qWarnings.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130207/7d58f039/attachment.html>


More information about the Plasma-devel mailing list