Review Request 107600: Keep placeholder text visible when empty and focused

[Aurélien Gâteau]

> On Dec. 13, 2012, 5:32 p.m., Aaron J. Seigo wrote:
> > as this is indeed a rather widely shifting style (far beyond KDE), as long as it is consistent with kdelibs and Qt i'm ok with this. and consistency is the hard bit. yes, there is 107678 for kdelibs (which is half the battle) but that leaves Qt. if your patch makes it into qt (4 or 5) then i'll put my ShipIt! on this and 107678 ...
> > 
> > given that we face this same issue in krunner, i'd like to see the change made ... i'm just very unhappy about having different behaviours between the "same" Qt and KDE widgets.
> 
> Aurélien Gâteau wrote:
>     Makes sense. I am planning on providing a patch for Qt anyway. In the long run we should even be able to replace KLineEdit::clickMessage implementation to QLineEdit::placeHolder.
> 
> Aaron J. Seigo wrote:
>     "In the long run we should even be able to replace KLineEdit::clickMessage implementation to QLineEdit::placeHolder."
>     
>     that would really be the best thing :)
>     
>     (and given we can now submit changes to Qt, i hope that in future we'll create far fewer of these kinds of KDE-specific features)

Qt 5 now also keeps placeholder text visible when QLineEdit is focused ( https://codereview.qt-project.org/#change,45326 ). Can this change go in?


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107600/#review23416
-----------------------------------------------------------


On Dec. 12, 2012, 6:11 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107600/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch keeps the place holder text visible when a TextField is focused. This is useful for situations where a text field is focused at startup. We use it in Homerun for the search field.
> 
> I filed a similar review-request for kdelibs KLineEdit and KTextEdit: https://git.reviewboard.kde.org/r/107678/
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml d19e7d8 
> 
> Diff: http://git.reviewboard.kde.org/r/107600/diff/
> 
> 
> Testing
> -------
> 
> Ran widgetgallery with the patch code, as can be seen in attached screenshot.
> 
> 
> Screenshots
> -----------
> 
> TextField with placeholder from Widget Gallery
>   http://git.reviewboard.kde.org/r/107600/s/872/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130206/75350261/attachment.html>