Review Request 108699: fixes bug 309033

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108699/#review26739
-----------------------------------------------------------



plasmate/editors/metadata/metadataeditor.h
<http://git.reviewboard.kde.org/r/108699/#comment20297>

    typo: should be initCategories, not initCate*r*gories :)



plasmate/editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/108699/#comment20298>

    space between foreach and ( is missing



plasmate/editors/metadata/metadataeditor.cpp
<http://git.reviewboard.kde.org/r/108699/#comment20299>

    much easier: m_view->category_combo->addItems(m_categories);
    
    also, i imagine that m_view->category_combo should be cleared of entries first?


- Aaron J. Seigo


On Feb. 1, 2013, 2:29 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108699/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 2:29 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> 1. fixes bug 309033
> 2. replaces tabs with spaces
> 3. fixed the coding style
> 
> 
> This addresses bug 309033.
>     http://bugs.kde.org/show_bug.cgi?id=309033
> 
> 
> Diffs
> -----
> 
>   plasmate/editors/metadata/metadata.ui b91a5b7 
>   plasmate/editors/metadata/metadataeditor.h 4ce42ce 
>   plasmate/editors/metadata/metadataeditor.cpp 20c3a18 
> 
> Diff: http://git.reviewboard.kde.org/r/108699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130206/bbff8b55/attachment-0001.html>