Review Request 108797: Small adjustments in KSMServer UI, fixed error that wouldn't reproduce in default plasma themes

[Manuel Tortosa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108797/#review26723
-----------------------------------------------------------

Ship it!


Tested with 2 different plasma themes without image. works as expected.

- Manuel Tortosa


On Feb. 6, 2013, 12:36 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108797/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 12:36 a.m.)
> 
> 
> Review request for Plasma, Lamarque Vieira Souza and Manuel Tortosa.
> 
> 
> Description
> -------
> 
> This patch fixes a problem that appeared when the Shutdown dialog was displayed and the theme didn't offer the moon image. This patch fixes this for properly anchoring the text item that says "Shutting down in X seconds".
> 
> Additionally it adds a feature in the test so that you can select what theme to run it in. It's interesting for reproducing this kind of problems.
> 
> 
> This addresses bug 313778.
>     http://bugs.kde.org/show_bug.cgi?id=313778
> 
> 
> Diffs
> -----
> 
>   ksmserver/themes/default/main.qml 4dea4b9 
>   ksmserver/tests/test.cpp c104edf 
> 
> Diff: http://git.reviewboard.kde.org/r/108797/diff/
> 
> 
> Testing
> -------
> 
> Ran testsh in many different setups.
> 
> 
> File Attachments
> ----------------
> 
> Caledonia
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/06/ksmserver-caledonia.png
> Air
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/06/ksmserver-default.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130206/e3c151fa/attachment.html>