Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself
Aurélien Gâteau
agateau at kde.org
Tue Feb 5 09:02:43 UTC 2013
> On Feb. 1, 2013, 7:38 p.m., Aaron J. Seigo wrote:
> > plasma/declarativeimports/plasmacomponents/qmenu.cpp, line 299
> > <http://git.reviewboard.kde.org/r/108700/diff/1/?file=111521#file111521line299>
> >
> > we try not to use slot* names (as they tend to drift over time from the signals connected and/or other uses), but rather state what the method does.
> >
> > so in this case perhaps "menuClosing()" or sth
OK. When I do not prefix methods with "slot", I like to use a verb as the first word. Would "markAsClosed()" work for you?
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108700/#review26519
-----------------------------------------------------------
On Feb. 1, 2013, 4:04 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108700/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 4:04 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Make sure Menu.status is set to Closed when the menu closes itself
>
>
> Diffs
> -----
>
> plasma/declarativeimports/plasmacomponents/qmenu.h 00b73e47f1bbfe12aa1f6d5f7dfc8de7f7a0dfe1
> plasma/declarativeimports/plasmacomponents/qmenu.cpp e91c365e401d751d42430eca36dea42f1258ee50
>
> Diff: http://git.reviewboard.kde.org/r/108700/diff/
>
>
> Testing
> -------
>
> Run attached testmenu.qml program. Without the patch, the text says "Opened" even after closing the menu.
>
>
> File Attachments
> ----------------
>
> Test program
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/01/testmenu.qml
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130205/d446b28b/attachment.html>
More information about the Plasma-devel
mailing list