Review Request 114634: Make playlist switching code simpler
Commit Hook
null at kde.org
Tue Dec 24 15:59:06 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114634/#review46140
-----------------------------------------------------------
This review has been submitted with commit f97a0058da64b62f1b0990ffde29552f58e721e1 by Shantanu Tushar to branch master.
- Commit Hook
On Dec. 23, 2013, 7:20 p.m., Shantanu Tushar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114634/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2013, 7:20 p.m.)
>
>
> Review request for Plasma and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Separate methods for switching and set'ing a new playlist aren't really necessary. This patch eliminates the duplication, and also introduces some more cleanup to related methods.
>
>
> Diffs
> -----
>
> libs/mediacenter/multipleplaylistmodel.cpp 10ccb40
> libs/mediacenter/playlistmodel.h 5a4ac8c
> libs/mediacenter/playlistmodel.cpp cac6154
>
> Diff: https://git.reviewboard.kde.org/r/114634/diff/
>
>
> Testing
> -------
>
> Adding/removing playlist, adding/removing media, removing default playlist work fine.
>
>
> Thanks,
>
> Shantanu Tushar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131224/76b1e33a/attachment.html>
More information about the Plasma-devel
mailing list