Review Request 114634: Make playlist switching code simpler

Shantanu Tushar shantanu at kde.org
Mon Dec 23 19:20:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114634/
-----------------------------------------------------------

(Updated Dec. 23, 2013, 7:20 p.m.)


Review request for Plasma and Sinny Kumari.


Changes
-------

Remove unused Q_PROPERTY and NOTIFY signal


Repository: plasma-mediacenter


Description
-------

Separate methods for switching and set'ing a new playlist aren't really necessary. This patch eliminates the duplication, and also introduces some more cleanup to related methods.


Diffs (updated)
-----

  libs/mediacenter/multipleplaylistmodel.cpp 10ccb40 
  libs/mediacenter/playlistmodel.h 5a4ac8c 
  libs/mediacenter/playlistmodel.cpp cac6154 

Diff: https://git.reviewboard.kde.org/r/114634/diff/


Testing
-------

Adding/removing playlist, adding/removing media, removing default playlist work fine.


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131223/f46af6a3/attachment.html>


More information about the Plasma-devel mailing list