Review Request 114589: Fix leaks in MouseEventListener

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114589/#review46067
-----------------------------------------------------------

Ship it!


Thanks for both the fix and the documentation!

- Marco Martin


On Dec. 21, 2013, 8:01 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114589/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 8:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> 
> Fix memory issues in MouseEventListener
> 
> Delete KDeclarativeMouseEvent when emitted
> 
> Do not leak KDeclarativeMouseEvent press and hold events when the mouse
> moves.
> 
> Do not create KDeclarativeMouseEvent when the mouse is hovered. It's
> pointless.
> 
> 
> Add documentation for MouseEventListener
> 
> Add a simple manual test for MouseEventListener
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/qtextracomponents/mouseeventlistener.h 7940846 
>   src/declarativeimports/qtextracomponents/mouseeventlistener.cpp 8f925dd 
>   src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131223/5495adda/attachment.html>