Review Request 114271: drawFloatFrame for QtQuick menus

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114271/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 12:03 p.m.)


Review request for Plasma, David Edmundson and Hugo Pereira Da Costa.


Changes
-------

using the inherits variant as the styleObject is set now in QtQuick Controls


Repository: kde-workspace


Description
-------

drawFrameMenuPrimitive is entered with a null QWidget if a QQuickMenu is rendered. By handling this case we get the menu to render with a frame. Unfortunately we cannot render the widget background as that really needs a non-null QWidget and we also do not yet get shadows.


Diffs (updated)
-----

  kstyles/oxygen/oxygenstyle.cpp 1271e07 

Diff: http://git.reviewboard.kde.org/r/114271/diff/


Testing
-------

I'm not sure whether this can affect other areas if QWidget is null.


File Attachments
----------------

QtQuick menu with fix
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/32336a9f-5bd7-4f47-974f-3420882f7cc3__qml-menu-fixed.png
QtQuick menu without fix
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/03/45e57c8b-324d-4d9a-8fc8-52211f2e8f8d__qml-menu-broken.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131216/3115a4df/attachment.html>