Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

[Heena Mahour]

> On Dec. 13, 2013, 7:53 a.m., Sujith Haridasan wrote:
> > mediaelements/mediawelcome/HomeScreenFooter.qml, line 42
> > <http://git.reviewboard.kde.org/r/114428/diff/2/?file=224654#file224654line42>
> >
> >     The PMC time doesn't get synced with desktop time. Can you tune this further to get it synced?
> 
> Shantanu Tushar wrote:
>     Also, this is the matter of #114429 . This review should only be about Text -> Label. Heena can you update the diff?
> 
> Heena Mahour wrote:
>     @Shantanu , yeah this was showed in the this diff to , and somehow removing it is creating a trouble in opening the diff ,so I just modified it here too :-P
> 
> Shantanu Tushar wrote:
>     well if you got your diffs messed up, I'd suggest create a fresh patch for this review request which has only Text -> Label changes. These are trivial changes so you can just re-do the changes by hand.
>     Also, to avoid this from next time, always work on things in their respective branches so they don't conflict.
>     
>     We will review this once the diff doesn't have the changes for the time display.

done


- Heena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
-----------------------------------------------------------


On Dec. 13, 2013, 3:05 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114428/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 3:05 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Replaced Text {} by PlasmaComponents.Label {} 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
> 
> Diff: http://git.reviewboard.kde.org/r/114428/diff/
> 
> 
> Testing
> -------
> 
> works fine .
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131213/3bdc9ff4/attachment.html>