Review Request 114429: use of time data engine -> less code

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114429/#review45637
-----------------------------------------------------------



mediaelements/mediawelcome/CategoriesListDelegate.qml
<http://git.reviewboard.kde.org/r/114429/#comment32598>

    if the component is not visible, then this shouldn't be a necessary change: it just makes it more heavyweight.
    
    the real problem here is using a visual item to store data at all.
    
    apparently this is just to bind a value to an alias (currentCategory); i would suggest tracking down where that is used and coming up with a different solution



mediaelements/mediawelcome/HomeScreenFooter.qml
<http://git.reviewboard.kde.org/r/114429/#comment32597>

    this is incorrect; if you are using a DataEngine with an interval, then you let the DataEngine update you.
    
    so the Timer here should just go away and the label with the text should be bound to the results of the DataSource.


- Aaron J. Seigo


On Dec. 13, 2013, 7:07 a.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114429/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 7:07 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Replaced Text{} by Label {}
> Time Data engine instead of creating Date() and hours -> less code !
> text color is predefined in Label {} 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 
>   mediaelements/mediawelcome/CategoriesListDelegate.qml f011bae 
>   mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 
>   mediaelements/mediawelcome/HomeScreenText.qml 35cd20a 
> 
> Diff: http://git.reviewboard.kde.org/r/114429/diff/
> 
> 
> Testing
> -------
> 
> yeah ,works fine ,displays days as well now.
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131213/3f52a84e/attachment-0001.html>