Review Request 114400: Port geolocation dataEngine

Sebastian Kügler sebas at kde.org
Wed Dec 11 11:39:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114400/#review45531
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Dec. 11, 2013, 11:33 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114400/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 11:33 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> port geolocation dataengine
> 
> Note: Which package ships libgps?
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt c6eb55d 
>   plasma/generic/dataengines/geolocation/CMakeLists.txt f270eb0 
>   plasma/generic/dataengines/geolocation/geolocation.h 5d23872 
>   plasma/generic/dataengines/geolocation/geolocation.cpp f292cc9 
>   plasma/generic/dataengines/geolocation/location_ip.cpp 855fec0 
> 
> Diff: http://git.reviewboard.kde.org/r/114400/diff/
> 
> 
> Testing
> -------
> 
> works as expected
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131211/0f60662d/attachment.html>


More information about the Plasma-devel mailing list