Review Request 114380: Port share dataengine

[Bhushan Shah]

> On Dec. 10, 2013, 8:30 p.m., Sebastian Kügler wrote:
> > plasma/generic/dataengines/share/shareengine.cpp, line 118
> > <http://git.reviewboard.kde.org/r/114380/diff/1/?file=223653#file223653line118>
> >
> >     I don't see where this json file is generated. Is it at all?

data/CMakeLists.txt


> On Dec. 10, 2013, 8:30 p.m., Sebastian Kügler wrote:
> > plasma/generic/dataengines/share/share_package.cpp, line 28
> > <http://git.reviewboard.kde.org/r/114380/diff/1/?file=223652#file223652line28>
> >
> >     Don't we need to call initPackage here or is that done later? (Haven't looked at the entire engine code.)

it gets called at K_EXPORT_PLASMA_PACKAGE(share, SharePackage)


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114380/#review45461
-----------------------------------------------------------


On Dec. 10, 2013, 8:24 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114380/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 8:24 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Will port away from KDE4Support soon
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 11a90d1 
>   plasma/generic/dataengines/share/CMakeLists.txt a68ed0d 
>   plasma/generic/dataengines/share/data/CMakeLists.txt PRE-CREATION 
>   plasma/generic/dataengines/share/plugin_share_package.cpp ac81a31 
>   plasma/generic/dataengines/share/share_package.h 00df488 
>   plasma/generic/dataengines/share/share_package.cpp a31c6c5 
>   plasma/generic/dataengines/share/shareengine.cpp 86c308f 
>   plasma/generic/dataengines/share/shareservice.cpp b789439 
> 
> Diff: http://git.reviewboard.kde.org/r/114380/diff/
> 
> 
> Testing
> -------
> 
> works as expected
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131210/2493d0f4/attachment.html>