Review Request 114334: Use IconEffect for disabled state in QIconItem

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114334/#review45269
-----------------------------------------------------------


This review has been submitted with commit 1d28b028b17f243b6609c49b21b5cde61cbd6236 by Martin Gräßlin to branch master.

- Commit Hook


On Dec. 6, 2013, 2:25 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114334/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Reason for this change: a QIcon might not contain the disabled pixmaps. Using the icon effect allows to get also the disabled state for such icons.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/qtextracomponents/qiconitem.cpp 93b32d3 
> 
> Diff: http://git.reviewboard.kde.org/r/114334/diff/
> 
> 
> Testing
> -------
> 
> Yes, with new code for KWin (icon from window -> no disabled pixmap).
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131206/45786dba/attachment.html>