Review Request 114334: Use IconEffect for disabled state in QIconItem

Martin Gräßlin mgraesslin at kde.org
Fri Dec 6 14:25:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114334/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Reason for this change: a QIcon might not contain the disabled pixmaps. Using the icon effect allows to get also the disabled state for such icons.


Diffs
-----

  src/declarativeimports/qtextracomponents/qiconitem.cpp 93b32d3 

Diff: http://git.reviewboard.kde.org/r/114334/diff/


Testing
-------

Yes, with new code for KWin (icon from window -> no disabled pixmap).


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131206/be2f0ce1/attachment.html>


More information about the Plasma-devel mailing list