Review Request 114318: Adding keyboard navigation support for popupmenu.

Shantanu Tushar shantanu at kde.org
Thu Dec 5 17:39:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114318/#review45212
-----------------------------------------------------------

Ship it!


Ship It!


shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/114318/#comment32313>

    looks like there is no real change in this file, please only commit this if needed


- Shantanu Tushar


On Dec. 5, 2013, 5:35 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114318/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 5:35 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Adding keyboard navigation support for popup menu. Like 
> a) using up/down arrow keys to navigate the popup menu.
> b) Pressing the return to do same action which a mouse click does on popupmenu.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 78d24c6 
>   mediaelements/popupmenu/PopupMenu.qml 3ef66bb 
> 
> Diff: http://git.reviewboard.kde.org/r/114318/diff/
> 
> 
> Testing
> -------
> 
> Done testing both with mouse and keyboard. It worked fine.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131205/08e8a993/attachment-0001.html>


More information about the Plasma-devel mailing list