Review Request 114253: Port favicons dataengine to KF5

Andrea Scarpino scarpino at kde.org
Thu Dec 5 10:48:22 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114253/
-----------------------------------------------------------

(Updated Dec. 5, 2013, 11:48 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

David's fixes.


Repository: kde-workspace


Description
-------

= subject.

I replaced KUrl by QUrl and KStandardDirs by QStandardPaths. Please check if I replaced them correctly.


Diffs (updated)
-----

  plasma/generic/dataengines/CMakeLists.txt 3e94325 
  plasma/generic/dataengines/favicons/CMakeLists.txt 4af0f14 
  plasma/generic/dataengines/favicons/faviconprovider.h 1f370f9 
  plasma/generic/dataengines/favicons/faviconprovider.cpp bc72a66 
  plasma/generic/dataengines/favicons/favicons.h 79565bf 
  plasma/generic/dataengines/favicons/favicons.cpp 2eae673 

Diff: http://git.reviewboard.kde.org/r/114253/diff/


Testing
-------

Builds.


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131205/d7793afe/attachment.html>


More information about the Plasma-devel mailing list