Review Request 114295: Fix textfield/lineedit hover frame with QtQuickControls

David Edmundson david at davidedmundson.co.uk
Wed Dec 4 12:19:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114295/#review45086
-----------------------------------------------------------

Ship it!


Nice, can you fix TextArea too whilst you're at it?

- David Edmundson


On Dec. 4, 2013, 11:24 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114295/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 11:24 a.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The QtQuickControls' textfield does not have a hover frame as it fails the input widget test (as widget == 0 when called from QQC), so the test is expanded to check if it's QQC textfield ("edit").
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 50c217f 
> 
> Diff: http://git.reviewboard.kde.org/r/114295/diff/
> 
> 
> Testing
> -------
> 
> QQC textfield gets nice hover frame when mouse hovers over it.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131204/d28d6de3/attachment.html>


More information about the Plasma-devel mailing list