Review Request 112375: Correctly determine frame width when called from QtQuickControls
David Edmundson
david at davidedmundson.co.uk
Fri Aug 30 15:55:49 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112375/
-----------------------------------------------------------
(Updated Aug. 30, 2013, 3:55 p.m.)
Review request for Plasma and Hugo Pereira Da Costa.
Summary (updated)
-----------------
Correctly determine frame width when called from QtQuickControls
Description (updated)
-------
Correctly determine frame width when called from QtQuickControls
When oxygen is used in QtQuickControls the widget parameter is empty
as such we need to determine the widget type (lineedit etc. ) in a
different way
Diffs (updated)
-----
kstyles/oxygen/oxygenstyle.cpp 86b5cdf3054f5d362d90f0f76c30bfb4f2646911
Diff: http://git.reviewboard.kde.org/r/112375/diff/
Testing
-------
File Attachments
----------------
QML After
http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1.png
QML_Before
http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/spell1_1.png
Normal oxygen demo
http://git.reviewboard.kde.org/media/uploaded/files/2013/08/30/oxygen1.png
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130830/d6eb84de/attachment-0001.html>
More information about the Plasma-devel
mailing list