Review Request 112329: Oxygen Style: Check widget validity in group box drawing

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112329/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 5:24 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Description
-------

Check widget validity in group box drawing

Widget is an optional parameter and may be 0.
This currently causes a crash when GroupBox is used by QtQuickControls

--

Not sure which group to set, please reassign if plasma is wrong.


Diffs
-----

  kstyles/oxygen/oxygenstyle.cpp 801bf2195edf8114c5f0ea9b9d1235711bc5728a 

Diff: http://git.reviewboard.kde.org/r/112329/diff/


Testing
-------

Created QML test app to recreate some of OxygenDemo
No longer crashes \o/


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130828/1fd6937c/attachment.html>