Review Request 111849: custom first week for plasmaclock.

[Sebastian Kügler]

> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote:
> > * The patch is not correctly submitted, it's submitted as screenshot, not as patch, that makes it impossible to review
> > * You didn't attach a screenshot of the UI
> > * Checking wether a patch applies is not testing it
> > * The clock's config is not the right place for this, it should rather be a global calendar setting
> > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not about)
> > 
> > Please read and address my comments more carefully.
> 
> Hu Zheng wrote:
>     If I submit it as a patch, it will need a Parent Diff, which I don't have in fact.
>     The screenshot is added!
>     You can see the new patch file, it changed to use custom config file.

The parent diff is optional. Please also address my other comments.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38189
-----------------------------------------------------------


On Aug. 24, 2013, 7:46 a.m., Hu Zheng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 7:46 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period!
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
> 
> 
> Testing
> -------
> 
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
> 
> The save configuration codes are not very beautiful, but it works fine!
> 
> 
> File Attachments
> ----------------
> 
> patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png
> 
> 
> Thanks,
> 
> Hu Zheng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/611848ac/attachment.html>