Review Request 112236: krunner: Add the full name of completion matches to history

[Martin Gräßlin]

> On Aug. 24, 2013, 12:08 p.m., Thomas Lübking wrote:
> > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274
> > <http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274>
> >
> >     ... ;-)
> 
> Harald Hvaal wrote:
>     yeah, not sure what happened with post-review here, but it's definitely not part of the actual commit :)

post-review happily includes any changes you have in a tree. Always do git stash before using it ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38466
-----------------------------------------------------------


On Aug. 24, 2013, 11:52 a.m., Harald Hvaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2013, 11:52 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Previously you would not record the actual item you chose after choosing an auto-completion, so if you typed say "lal" and you chose a completion way down the list, the history item would not reflect that choice, only what you typed to get to the completion list.
> 
> This commit will fill the history combo box with the actual hit you executed, instead of half-complete strings that don't make sense until you actually select them.
> Exact matches are added as-is.
> 
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the history, "Qt Assistant" will be added.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml 8832d1d03e47a4e6382877d18ee664ecd4d12343 
> 
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Hvaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130824/6b13c23c/attachment.html>