Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.
Commit Hook
null at kde.org
Wed Aug 21 16:51:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/#review38288
-----------------------------------------------------------
This review has been submitted with commit 64505f15b9725d3d213990c5fce7f1fc2e41acc7 by Jeremy Whiting to branch KDE/4.11.
- Commit Hook
On Aug. 21, 2013, 4:50 p.m., Jeremy Paul Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112128/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2013, 4:50 p.m.)
>
>
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian Kügler.
>
>
> Description
> -------
>
> Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails. This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.
>
>
> Diffs
> -----
>
> plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46
>
> Diff: http://git.reviewboard.kde.org/r/112128/diff/
>
>
> Testing
> -------
>
> Plasma themes correctly uninstall here with this and my other patch.
>
>
> Thanks,
>
> Jeremy Paul Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/605e3919/attachment.html>
More information about the Plasma-devel
mailing list