Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/#review38285
-----------------------------------------------------------

Ship it!


looks good to me

- Marco Martin


On Aug. 17, 2013, 3:03 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112128/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2013, 3:03 a.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Currently uninstallation of plasma themes is very broken for a couple of reasons. One reason is that the tar packages downloaded from kde-look and other kns services contain a subfolder with the theme name, that then contains the metadata.desktop file that plasma::PackageStructure looks for in order to uninstall or install a plugin. The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah fails.  This patch fixes the second issue. I'll upload another patch for review that fixes the first issue.
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 
> 
> Diff: http://git.reviewboard.kde.org/r/112128/diff/
> 
> 
> Testing
> -------
> 
> Plasma themes correctly uninstall here with this and my other patch.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130821/25580a3b/attachment.html>