Review Request 112157: replace deprecated widgets

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/#review38202
-----------------------------------------------------------


Looking good, apart from the issue David pointed out, and small comments inline.

Once you've looked into these, feel free to commit.


engineexplorer/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112157/#comment28229>

    Can we now get rid of these, or either of them? (Just try a build without them, and see what can go away.)



engineexplorer/engineexplorer.h
<http://git.reviewboard.kde.org/r/112157/#comment28230>

    should move up now, to the other Qt includes


- Sebastian Kügler


On Aug. 19, 2013, 2:45 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112157/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 2:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> * this replaces the deprecated widgets from the plasmaengineexplorer
> * makes the serviceviewer.ui nicer( I have attached a screenshot) 
> 
> 
> Diffs
> -----
> 
>   engineexplorer/CMakeLists.txt 1466542 
>   engineexplorer/engineexplorer.h 5c19fa6 
>   engineexplorer/engineexplorer.cpp a3f2e1f 
>   engineexplorer/engineexplorer.ui 65e70b4 
>   engineexplorer/ktreeviewsearchline.cpp 734ef94 
>   engineexplorer/main.cpp 8eae7a3 
>   engineexplorer/serviceviewer.h dc0b36b 
>   engineexplorer/serviceviewer.cpp d7e8e5a 
>   engineexplorer/serviceviewer.ui b91b784 
> 
> Diff: http://git.reviewboard.kde.org/r/112157/diff/
> 
> 
> Testing
> -------
> 
> it is building/installing/working correctly. I have noticed any issue
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130820/3f266c08/attachment.html>