Review Request 112073: Partially revert commit 83d3018

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112073/#review38112
-----------------------------------------------------------


This is ... extremely surprising.
plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? That's what "unique" expects (while "multi" expects the PID appended).

In addition, I didn't experience any problems with startup and the splash screen...

Are you really sure this change fixes anything? I could be wrong, but I'm rather surprised.

- David Faure


On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112073/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 12:01 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Description
> -------
> 
> While the commit may be technically correct, it breaks ksplash for 4.11 release...
> I've changed unique to multi, if there is a better solution, please hint it ;-)
> (maybe actually someone meant multi, when typing wait :-)
> 
> 
> This addresses bug 321695.
>     http://bugs.kde.org/show_bug.cgi?id=321695
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 
> 
> Diff: http://git.reviewboard.kde.org/r/112073/diff/
> 
> 
> Testing
> -------
> 
> Yes... starts "normally" as previously/ksplash isn't interupted
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130819/c6589928/attachment.html>