Review Request 107908: Fix dismissing LastNotificationPopup often failing

[Albert Astals Cid]

> On April 24, 2013, 6:51 p.m., Marco Martin wrote:
> > Ship It!
> 
> Albert Astals Cid wrote:
>     Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting?
>
> 
> Kai Uwe Broulik wrote:
>     Marco did some changes to that part in the meantime [1] and I cannot really reproduce the problem anymore for a long time now, seems the close signal is emitted even when you're dragging the popup on the button and then release.
>     
>     [1] http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=77a3bf4aca1e876fd234eaa15ad58f984b6b9d54
>

So shall we discard this?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------


On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
> Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
> 
> 
> This addresses bug 311413.
>     http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130816/84f0817c/attachment.html>