Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + better layout for 3 action buttons

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108325/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 10:03 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Marco Martin.


Description
-------

Fixes the LastNotificationsPopup moving around when clicking on a button and adds a move button to freely place it all over the desktop. 
Also this removes notifications jobs from the notification icon. (So clicking on X does not hide but really closes the notification and removes it)
Also this fixes layout problems with 3 buttons displayed inside a notification (this caused the X button to overlap with the upper actionbutton).

As my original diff was not recognized as normal diff(don't know what I did wrong there) I attached the patch directly to this thread. 


This addresses bug 311413.
    http://bugs.kde.org/show_bug.cgi?id=311413


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/108325/diff/


Testing
-------

kdialog --passivepopup "bla"
click on X, closes and removes job from notification Icon
click and hold on move button moves the popup freely on the screen. 


File Attachments
----------------

Patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff


Thanks,

Leszek Lesner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/0e9c6fcf/attachment.html>