Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112105/#review37870
-----------------------------------------------------------

Ship it!


meh, i changed it because some reported leaks since the expected way is that the stack owns and deletes the page apparently (the other implementations of pagestack, like qtcontrols, ubuntu and meego do this, so is also a porting issue)

so yeah, will have to use this workaround... (if there isn't a better idea)

- Marco Martin


On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112105/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 5:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> In KDE 4.11, if you do not parent a page after popping it from PageStack, it will be deleted by QML's garbage collector. This creates erratic behavior such as stopping playback the moment the user presses back from media player.
> This patch reparents the page to the root element (and hides it) to prevent the deletion.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112105/diff/
> 
> 
> Testing
> -------
> 
> Doesn't seem to affect any workflow. Things to look out are weird placements of the media elements (browser, player etc) due to the reparenting while going back/into some mode.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130815/037b8030/attachment-0001.html>