Review Request 112033: Drop windowId property from PlasmaCore.Dialog

[Ivan Čukić]

> On Aug. 12, 2013, 5:50 p.m., Ivan Čukić wrote:
> > Isn't it also used for reporting wid to share-like-connect (activity manager) in some applications?
> 
> Martin Gräßlin wrote:
>     well it got introduced for KWin:
>     
>     commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0
>     Author: Martin Gräßlin <mgraesslin at kde.org>
>     Date:   Sat Mar 24 10:51:12 2012 +0100
>     
>         Export WindowId on Plasma Dialog
>         
>         Exporting the window Id allows to use it in declarative KWin scripts
>         to embedd window thumbnails on the dialog.
>         
>         REVIEW: 104393
>     
>     ---
>     do you have an example of how it is used? Because most likely it should be easy to port in that case, too.
>

This was a question for Marco - sorry for not explicitely specifying it. I'm just wondering whther he used it in image viewer, web browser ect. of Plasma Active.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review37602
-----------------------------------------------------------


On Aug. 12, 2013, 5:34 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:34 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Property windowId was according to the comments only provided because KWin needed it. KWin's usecase was to know the window Id of the window where a given item is rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding the item. This means this hack is no longer needed.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/dialog.h 7392b71 
>   src/declarativeimports/core/dialog.cpp eaf3dce 
> 
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
> 
> 
> Testing
> -------
> 
> Yes, KWin's ThumnailItem is still working
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130812/8d3ea8d2/attachment.html>