Review Request 111863: Feature: Folder Preview in Local Pictures Browsing
Shantanu Tushar
shantanu at kde.org
Thu Aug 8 18:18:41 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/#review37374
-----------------------------------------------------------
Ship it!
Works fine, just fix the little issues below and push
browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27652>
if needs braces {}
browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27651>
indentation needs to be fixed
- Shantanu Tushar
On Aug. 8, 2013, 2:30 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111863/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 2:30 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Description
> -------
>
> Folder Contents(Images) are previewed when we browse the local directories for Pictures.
>
>
> Diffs
> -----
>
> browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59
> browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3
> browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f
> browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION
> browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION
> browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c
> browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668
> browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386
> browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11
> browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4
>
> Diff: http://git.reviewboard.kde.org/r/111863/diff/
>
>
> Testing
> -------
>
> Yes. Works fine.
>
>
> Thanks,
>
> Akshay Ratan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130808/c23829fe/attachment.html>
More information about the Plasma-devel
mailing list