Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

[Aleix Pol Gonzalez]

> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote:
> > tier1/kconfig/src/gui/kconfigloader.h, line 112
> > <http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112>
> >
> >     This looks like it should be const
> >     
> >     I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now.
> 
> Martin Gräßlin wrote:
>     please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged.

Make you can add a comment or warning?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37219
-----------------------------------------------------------


On Aug. 6, 2013, 12:25 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111908/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Add KConfigLoader from Plasma Framework to KConfigGui
> 
> The ConfigLoader is way to awesome to not be directly in KConfig.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION 
>   tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION 
>   tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION 
>   tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130806/641b83e3/attachment-0001.html>