Fixing plasma theme removal

[Jeremy Whiting]

Hello,

Today I applied and pushed a fix to make uninstalling from KNS3 for most
cases work again, however https://bugs.kde.org/show_bug.cgi?id=149479 is
still broken for plasma theme uninstallation and here's why:

PlasmaStructure doesn't accept application/x-xz-compressed-tar format files
which 'Helium' theme is. Then plasmapkg -t theme -r filename is failing
since it's actually expecting the name of the theme rather than a plasma
package archive file.  Looking at the plasma-themes.knsrc we use plasmapkg
-t theme -i %f to install which works fine for .xz .gz and such archives,
but then uninstall we use plasmapkg -t theme -r %f with the same filename
and it fails.

So we either need to add a new command to plasmapkg to inspect a plasma
package to get it's name then we could do something like 'plasmapkg -r
`plasmapkg -n %f`' for removals if we added -n to get a plasma package's
name.

This "solution" has a problem though because opening the archives of plasma
themes fails since their metadata.desktop file's are in a subfolder of the
archive.  Even for plasmapkg -i themefile there's a warning saying the
metadata.desktop file wasn't found where it was expected. So we also need
to make plasmapkg extract the KTar directory's sources without the top
level folder, or make PlasmaStructure dive a folder deeper to look for the
metadata.desktop.

Any suggestions on which approach I should take would be greatly
appreciated.

thanks,
Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130802/7c42f1bc/attachment.html>