Review Request 110208: Fix memleak: make ~DialogShadows delete DialogShadows::Private

Commit Hook null at kde.org
Mon Apr 29 13:49:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110208/
-----------------------------------------------------------

(Updated April 29, 2013, 1:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.


Description
-------

Fix memleak: make ~DialogShadows delete DialogShadows::Private


Diffs
-----

  plasma/private/dialogshadows.cpp e787fd4ec4e39cab275328b5c69aad716c826788 
  plasma/private/dialogshadows_p.h a2d62ccbe6be7908e076409fd418f48027e5f5da 

Diff: http://git.reviewboard.kde.org/r/110208/diff/


Testing
-------

Ran Plasma, without crash, tooltips still work.
Ran upcoming, Plasma::Dialog-based, Colibri: the change makes Valgrind a bit happier.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130429/7b03d050/attachment.html>


More information about the Plasma-devel mailing list